CR-11473 bootstrap recovery from repo #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #296 +/- ##
==========================================
- Coverage 60.46% 60.44% -0.03%
==========================================
Files 17 17
Lines 3023 3036 +13
==========================================
+ Hits 1828 1835 +7
- Misses 1096 1101 +5
- Partials 99 100 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
cmd/commands/repo.go
Outdated
| } else { | ||
| return fmt.Errorf("folder %s already exist in: %s", folder, repofs.Join(repofs.Root(), folder)) | ||
| } | ||
| } else { |
| "password": []byte("foo"), | ||
| }, | ||
| }) | ||
| f.EXPECT().Apply(gomock.Any(), gomock.Any()). |
There was a problem hiding this comment.
I would also assert that repo persist is not called.
roi-codefresh
approved these changes
May 8, 2022
Co-authored-by: roi-codefresh <[email protected]>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.